From 078bf9f4187269eb63669e080d6f8e3759d9a5f0 Mon Sep 17 00:00:00 2001 From: Reza Rezvani Date: Wed, 12 Nov 2025 12:59:58 +0100 Subject: [PATCH] fix(ci): add missing PR template enhancements - Add CI/CD workflow change type - Expand checklist with quality gates sections - Add Conventional Commits and branch naming reminders - Better organize code quality, docs, testing, CI/CD sections This file was modified in Phase 2 but accidentally not staged. --- .github/PULL_REQUEST_TEMPLATE.md | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 51409cb..87cfa7f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -13,10 +13,14 @@ Provide a clear and concise description of your changes. - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition/improvement +- [ ] CI/CD workflow change ## Related Issues -Fixes #(issue_number) + + +Closes #(issue_number) + ## Changes Made @@ -45,13 +49,31 @@ Add screenshots to help explain your changes. ## Checklist +### Code Quality - [ ] My code follows the project's style guidelines +- [ ] Python syntax is valid (if applicable) +- [ ] Bash scripts have valid syntax (if applicable) +- [ ] Markdown files are properly formatted +- [ ] No hardcoded secrets or sensitive data - [ ] I have commented my code where necessary + +### Documentation - [ ] I have updated the documentation (if needed) -- [ ] I have updated CHANGELOG.md with my changes -- [ ] My changes generate no new warnings +- [ ] I have updated CHANGELOG.md with my changes (for releases) +- [ ] README.md is updated if user-facing changes + +### Testing - [ ] I have tested my changes thoroughly -- [ ] All existing tests still pass +- [ ] Tested installation (./install.sh or install.ps1) +- [ ] Tested slash command (/enhance-claude-md) if applicable +- [ ] Tested guardian agent if applicable +- [ ] Tested on target environment (macOS/Linux/Windows) + +### CI/CD +- [ ] PR title follows Conventional Commits format (e.g., `feat(installer): add feature`) +- [ ] Branch name follows convention (feature/, fix/, hotfix/, etc.) +- [ ] All quality gates passing +- [ ] No merge conflicts with target branch ## Additional Notes