Drop in-container auth — MetaMCP guards the user-facing edge

The MCP's port 8000 isn't exposed outside the private mcp-servers_mcp
Docker network, so only the MetaMCP gateway can ever reach it. MetaMCP
itself enforces auth at the gateway → MCP-client edge (bearer token in
its UI), which is the right layer for it. In-container Basic/Bearer was
defense-in-depth that turned out to be friction-in-depth.

Removed:
  - ag_bids_mcp/auth.py (HTTP Basic middleware)
  - tests/test_auth.py (3 tests covering the middleware)
  - AG_BIDS_MCP_USER / AG_BIDS_MCP_PASS env vars from .env.example, README,
    docker-compose.snippet.yml, and deploy/README.md

Server.py simplified — direct `mcp.run(transport=...)` like zerto-docs-mcp,
no Starlette wrapping. 21 tests passing.

Live on 192.168.0.2: container recreated, real MCP initialize handshake
returns 200 + capability metadata over the mcp-servers_mcp network with
no auth header.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-20 16:05:41 -04:00
parent 8aa4cc0ef3
commit e78733d55e
7 changed files with 46 additions and 294 deletions
-102
View File
@@ -1,102 +0,0 @@
"""HTTP Basic middleware tests."""
from __future__ import annotations
import base64
import importlib
import os
import sys
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), "..")))
def _reload_auth(monkeypatch, user="alice", password="hunter2"):
monkeypatch.setenv("AG_BIDS_MCP_USER", user)
monkeypatch.setenv("AG_BIDS_MCP_PASS", password)
from ag_bids_mcp import auth
importlib.reload(auth)
return auth
def _b64(creds: str) -> str:
return base64.b64encode(creds.encode()).decode()
def test_expected_credentials_requires_both(monkeypatch):
monkeypatch.delenv("AG_BIDS_MCP_USER", raising=False)
monkeypatch.delenv("AG_BIDS_MCP_PASS", raising=False)
from ag_bids_mcp import auth
importlib.reload(auth)
import pytest
with pytest.raises(RuntimeError):
auth.expected_credentials()
monkeypatch.setenv("AG_BIDS_MCP_USER", "alice")
monkeypatch.delenv("AG_BIDS_MCP_PASS", raising=False)
importlib.reload(auth)
with pytest.raises(RuntimeError):
auth.expected_credentials()
def test_middleware_via_starlette_app(monkeypatch):
"""End-to-end: a Starlette app with the middleware returns 401 / 200 correctly."""
auth = _reload_auth(monkeypatch, "alice", "hunter2")
from starlette.applications import Starlette
from starlette.middleware import Middleware
from starlette.middleware.base import BaseHTTPMiddleware
from starlette.responses import PlainTextResponse
from starlette.routing import Route
from starlette.testclient import TestClient
async def hello(request):
return PlainTextResponse("ok")
app = Starlette(
routes=[Route("/x", endpoint=hello)],
middleware=[Middleware(BaseHTTPMiddleware, dispatch=auth.basic_auth_middleware)],
)
c = TestClient(app)
# No header -> 401 + WWW-Authenticate
r = c.get("/x")
assert r.status_code == 401
assert r.headers.get("www-authenticate", "").startswith("Basic")
# Wrong creds -> 401
r = c.get("/x", headers={"Authorization": "Basic " + _b64("alice:wrong")})
assert r.status_code == 401
# Wrong username, right password -> 401
r = c.get("/x", headers={"Authorization": "Basic " + _b64("eve:hunter2")})
assert r.status_code == 401
# Right creds -> 200
r = c.get("/x", headers={"Authorization": "Basic " + _b64("alice:hunter2")})
assert r.status_code == 200
assert r.text == "ok"
def test_malformed_authorization_header(monkeypatch):
auth = _reload_auth(monkeypatch)
from starlette.applications import Starlette
from starlette.middleware import Middleware
from starlette.middleware.base import BaseHTTPMiddleware
from starlette.responses import PlainTextResponse
from starlette.routing import Route
from starlette.testclient import TestClient
async def hello(request):
return PlainTextResponse("ok")
app = Starlette(
routes=[Route("/x", endpoint=hello)],
middleware=[Middleware(BaseHTTPMiddleware, dispatch=auth.basic_auth_middleware)],
)
c = TestClient(app)
# Not even base64
r = c.get("/x", headers={"Authorization": "Basic !!!not_b64!!!"})
assert r.status_code == 401
# Bearer instead of Basic
r = c.get("/x", headers={"Authorization": "Bearer abc"})
assert r.status_code == 401