Build out all 27 modules + capstone (#1)
Co-authored-by: claude <claude@jpaul.io> Co-committed-by: claude <claude@jpaul.io>
This commit was merged in pull request #1.
This commit is contained in:
@@ -0,0 +1,24 @@
|
||||
{
|
||||
"summary": "Adds a `clear` command. The core logic is fine, but the CLI handler never persists the change, so the command looks like it works while doing nothing on disk. No test covers the new behavior.",
|
||||
"recommendation": "request_changes",
|
||||
"comments": [
|
||||
{
|
||||
"file": "cli.py",
|
||||
"line": 49,
|
||||
"severity": "blocker",
|
||||
"comment": "The `clear` branch never calls save(tlist). The list is emptied in memory and the process exits, so tasks.json is untouched. It prints 'cleared all tasks' but the next `list` shows everything still there — a silent no-op. Add save(tlist) before printing."
|
||||
},
|
||||
{
|
||||
"file": "tasks.py",
|
||||
"line": 28,
|
||||
"severity": "suggestion",
|
||||
"comment": "No test covers clear(). Add one that adds two tasks, calls clear(), and asserts the list is empty — matching the Module 13 suite style."
|
||||
},
|
||||
{
|
||||
"file": "tasks.py",
|
||||
"line": 28,
|
||||
"severity": "nit",
|
||||
"comment": "clear() rebinds with self.tasks = []; self.tasks.clear() is equivalent and avoids replacing the list object. Minor."
|
||||
}
|
||||
]
|
||||
}
|
||||
Reference in New Issue
Block a user