justin/ai-workflow-course
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Testing/CI/tooling consistency (#9,#20,#21,#22,#23,#28) (#59)

Browse Source 
Co-authored-by: claude <claude@jpaul.io>
Co-committed-by: claude <claude@jpaul.io>
This commit was merged in pull request #59.
This commit is contained in:
Claude (agent)
2026-06-22 16:07:58 -04:00
committed by Claude (agent)
parent a6a3cfdc50
commit 391df7fc6d
17 changed files with 216 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/23-working-with-existing-codebases/lab/skills/safe-change.md
+6 -2
View File
@@ -22,8 +22,12 @@ When making a concrete change to an unfamiliar repo.
1. **State the change in one sentence** and the acceptance criterion ("done when X").
2. **Find the blast radius first:** search for every caller/usage of what you're about to touch.
List them. If you can't enumerate them, you're not ready to change it.
3. **Run the existing tests before touching anything** — establish a green baseline. If they were
already red, note it; don't let a pre-existing failure get blamed on you.
3. **Install the project's dependencies, then run the existing tests before touching anything** —
establish a green baseline. Tell two failures apart: if the suite errors with missing imports,
"no module named …", or "no tests ran," that's an **unconfigured environment**, not a baseline —
finish the documented install (and pick a different repo if it still won't go green on a clean
clone). A genuine **pre-existing failure** (install succeeded, but a real test fails) is the other
case — note it so it doesn't get blamed on you, and don't build on top of it.
4. **Make the minimal edit.** Keep it to the files identified in step 2.
5. **Add or extend a test** that fails without your change and passes with it.
6. **Run the full suite.** All green, including the baseline tests.