Onboarding + make M15 gate catch the plant + M17 override (#6,#17,#18,#19,#29) (#58)
Co-authored-by: claude <claude@jpaul.io> Co-committed-by: claude <claude@jpaul.io>
This commit was merged in pull request #58.
This commit is contained in:
@@ -1,15 +1,18 @@
|
||||
"""Cloud-sync config for tasks-app — a realistic snapshot of what an AI hands you.
|
||||
|
||||
Asked to "sync tasks to a cloud service," a model will cheerfully produce something like this: it
|
||||
works, it reads naturally, it passes lint and tests... and it has a live credential baked straight
|
||||
into the source. That is the *exact* failure mode Module 15's secret-scanning gate exists to catch.
|
||||
works, it reads naturally, it passes lint and tests... and it carries two planted flaws — a live
|
||||
credential baked straight into the source (caught by Gate 2, secret scanning) and a weak-crypto
|
||||
"signature" using MD5 (caught by Gate 3, SAST). Two different gates, two different blind spots.
|
||||
|
||||
DO NOT copy this pattern. The point of this file is to be caught by a scanner, not imitated.
|
||||
DO NOT copy these patterns. The point of this file is to be caught by a scanner, not imitated.
|
||||
The fix (read from the environment) is shown at the bottom, commented out, so you can see the
|
||||
difference once Part C of the lab is done.
|
||||
"""
|
||||
|
||||
# --- The problem the scanner should flag -------------------------------------------------------
|
||||
import hashlib
|
||||
|
||||
# --- The problem the SECRET scanner should flag (Gate 2) ---------------------------------------
|
||||
# A hardcoded API key. Looks like a normal string literal; lint and tests will never complain.
|
||||
SYNC_API_KEY = "sk_live_9c3f2a7b41d84e0fa6b2c5d8e1f09a73bdac46"
|
||||
SYNC_ENDPOINT = "https://api.example-task-cloud.com/v1/sync"
|
||||
@@ -19,6 +22,14 @@ def sync_headers() -> dict:
|
||||
return {"Authorization": f"Bearer {SYNC_API_KEY}"}
|
||||
|
||||
|
||||
# --- The problem the SAST scanner should flag (Gate 3) -----------------------------------------
|
||||
# AI-classic: "sign" the request body with a quick hash. MD5 is broken for anything
|
||||
# security-relevant — a textbook weak-crypto idiom. A secret scanner won't catch this (it's not a
|
||||
# secret); a SAST tool like bandit will (it's insecure code you wrote). DO NOT imitate.
|
||||
def sign_payload(body: str) -> str:
|
||||
return hashlib.md5(body.encode()).hexdigest()
|
||||
|
||||
|
||||
# --- The fix (Part C) --------------------------------------------------------------------------
|
||||
# Read the secret from the environment instead of committing it. Proper secret management — env
|
||||
# files, secret stores, per-environment config — is Module 17. This is just enough to make the
|
||||
|
||||
Reference in New Issue
Block a user