De-slop: remove every em-dash + banned words across all modules + capstone (#94)
Sync course wiki / sync-wiki (push) Successful in 4s
Sync course wiki / sync-wiki (push) Successful in 4s
Co-authored-by: claude <claude@jpaul.io> Co-committed-by: claude <claude@jpaul.io>
This commit was merged in pull request #94.
This commit is contained in:
@@ -1,11 +1,11 @@
|
||||
# Review rubric — the AI reviewer's instructions
|
||||
# Review rubric: the AI reviewer's instructions
|
||||
|
||||
This is the committed instruction set the AI reviewer reads before it looks at a diff. It lives in
|
||||
the repo on purpose: like the committed AI config from Module 5 and the skills from Module 21, a
|
||||
review rubric is a durable, versioned artifact. Change how the reviewer behaves and that change
|
||||
arrives as a diff in a PR, reviewable like any other.
|
||||
|
||||
Keep it short and opinionated. A vague rubric produces vague, noisy comments — the fastest way to
|
||||
Keep it short and opinionated. A vague rubric produces vague, noisy comments, the fastest way to
|
||||
get a team to ignore the AI reviewer entirely.
|
||||
|
||||
## What to check, in priority order
|
||||
@@ -17,7 +17,7 @@ get a team to ignore the AI reviewer entirely.
|
||||
3. **Security smells (Module 15).** Hardcoded secrets, shelling out on unsanitized input, a new
|
||||
dependency that doesn't obviously exist.
|
||||
4. **Correctness on edge cases.** Empty input, bad index, missing file.
|
||||
5. **Style nits — last, and clearly labeled.** Only if they matter. Nits drown signal.
|
||||
5. **Style nits, last, and clearly labeled.** Only if they matter. Nits drown signal.
|
||||
|
||||
## How to comment
|
||||
|
||||
|
||||
Reference in New Issue
Block a user