Tell the learner how to handle the editor git revert -m 1 HEAD opens in Module 12 (or add --no-edit) #43

New Issue

2026-06-22T14:23:58-04:00

claude commented

2026-06-22 14:23:58 -04:00

Problem

Part A step 6 runs git revert -m 1 HEAD with no -m message and no --no-edit, so unlike every other commit/merge step it drops the user into their configured commit editor (vi/vim by default on a fresh machine; nano on Ubuntu). The lab gives no instruction for handling it; the Key concepts section even says revert "opens an editor" but never how to save/quit. (Module 6 already shows an inline "save and close" note for the same behavior, so Module 12 is inconsistent.)

Evidence

modules/12-revert-reset-and-recovery/README.md Part A step 6 (~line 295): "git revert -m 1 HEAD # writes a NEW commit that undoes the whole merge". Steps 2/3 use -m "..."; this is the only step that drops into the editor. Key concepts (~line 72) notes "opens an editor" without how-to.

Why it matters

A clarity/consistency gap at a hands-on step; Module 6 sets the precedent of an inline editor note, which Module 12 omits.

Proposed change

Add a one-line note (preferred, since Key concepts teaches that revert opens an editor): "This opens your text editor with a pre-filled message — save and close (in vim, type :wq then Enter; in nano, Ctrl-O then Ctrl-X). Or add --no-edit to skip the editor." (git revert -m 1 HEAD --no-edit keeps the default "Revert …" message, so the step's expected output still holds.)

Acceptance criteria

The step tells the learner how to save/quit the editor (or how to skip it with --no-edit).
The expected "Revert …" commit still results.

Affected files

modules/12-revert-reset-and-recovery/README.md

References

Source finding F43 (realVotes 3/3).

Filed from an adversarial multi-agent course review (217 raw findings → 54 adversarially-verified survivors). Scoped for manual review; intentionally not auto-assigned to an agent.

## Problem Part A step 6 runs `git revert -m 1 HEAD` with no `-m` message and no `--no-edit`, so unlike every other commit/merge step it drops the user into their configured commit editor (vi/vim by default on a fresh machine; nano on Ubuntu). The lab gives no instruction for handling it; the Key concepts section even says revert "opens an editor" but never how to save/quit. (Module 6 already shows an inline "save and close" note for the same behavior, so Module 12 is inconsistent.) ## Evidence `modules/12-revert-reset-and-recovery/README.md` Part A step 6 (~line 295): "git revert -m 1 HEAD # writes a NEW commit that undoes the whole merge". Steps 2/3 use `-m "..."`; this is the only step that drops into the editor. Key concepts (~line 72) notes "opens an editor" without how-to. ## Why it matters A clarity/consistency gap at a hands-on step; Module 6 sets the precedent of an inline editor note, which Module 12 omits. ## Proposed change Add a one-line note (preferred, since Key concepts teaches that revert opens an editor): "This opens your text editor with a pre-filled message — save and close (in vim, type `:wq` then Enter; in nano, Ctrl-O then Ctrl-X). Or add `--no-edit` to skip the editor." (`git revert -m 1 HEAD --no-edit` keeps the default "Revert …" message, so the step's expected output still holds.) ## Acceptance criteria - [ ] The step tells the learner how to save/quit the editor (or how to skip it with `--no-edit`). - [ ] The expected "Revert …" commit still results. ## Affected files - `modules/12-revert-reset-and-recovery/README.md` ## References Source finding F43 (realVotes 3/3). --- *Filed from an adversarial multi-agent course review (217 raw findings → 54 adversarially-verified survivors). Scoped for manual review; intentionally not auto-assigned to an agent.*

claude added the ai-ready bug P2 labels 2026-06-22 14:23:58 -04:00

claude referenced a pull request that will close this issue

2026-06-22 17:30:31 -04:00

Recovery editor note + refresh CI action pins + scaffold M15 merge (#43,#44,#50) #66

claude referenced this issue from a commit

2026-06-22 17:30:32 -04:00

fix(modules-12,14,15,18,19,25): editor note, refresh CI action pins, scaffold M15 merge

claude closed this issue

2026-06-22 17:30:41 -04:00

Sign in to join this conversation.