Strip submit_doc_bug tool and gate (Zerto-specific, not applicable to label MCP)
This commit is contained in:
@@ -30,7 +30,7 @@ which phase they're on by inspecting:
|
||||
| `RERANK_URL` env unset in compose | Phase 6 not done |
|
||||
| `HYBRID_SEARCH` env unset, no `rag/bm25.py` content | Phase 8 not done |
|
||||
| No `eval/results/` directory | Phase 7 not done |
|
||||
| `find_doc_inconsistencies` / `submit_doc_bug` are commented-out stubs in `docs_mcp/server.py` | Phase 12 |
|
||||
| `find_doc_inconsistencies` is a commented-out stub in `docs_mcp/server.py` | Phase 12 |
|
||||
| No `corpus/.digest/` produced by CI | Phase 13 |
|
||||
|
||||
When in doubt, ask the user: *"Which phase from PLAN.md are we
|
||||
@@ -90,21 +90,6 @@ decide whether to call the tool. Treat it like a button label.
|
||||
*"Use when..."*, *"Call proactively whenever..."* phrasings work
|
||||
well. Don't bury the headline in implementation notes.
|
||||
|
||||
### Side-effecting tools must be env-gated AND operator-confirmed
|
||||
|
||||
Any tool that POSTs to an external service (submit_doc_bug being the
|
||||
canonical example):
|
||||
|
||||
1. Must check an env flag at call time and return a "disabled,
|
||||
manual fallback at <URL>" message if unset.
|
||||
2. Must have a loud docstring requiring per-call operator
|
||||
confirmation in the LLM conversation flow (the LLM drafts, shows
|
||||
the operator the exact payload, asks yes/no, only then calls).
|
||||
3. Must do upfront validation (URL allowlist, content length, etc.)
|
||||
so the LLM gets a clean error instead of a wire-level failure.
|
||||
|
||||
Match the `submit_doc_bug` patterns documented in PLAN.md Phase 12.
|
||||
|
||||
### Defensive fallback for retrieval components
|
||||
|
||||
The reranker, BM25 index, and any external dependency must fail
|
||||
@@ -231,7 +216,6 @@ python -m scrape.changelog --history-out corpus/.digest/history.jsonl --history-
|
||||
| "Add a reranker" | Read PLAN.md Phase 6. Stand up the llama.cpp sidecar, implement `_rerank()`. Verify with the eval harness. |
|
||||
| "Search is missing X queries" | Run the eval harness first to confirm the failure. Then consider: rich chunk-0 rewrites, hybrid retrieval, curated knowledge layer. Don't just tune cosine. |
|
||||
| "Let's add hybrid search" | Read PLAN.md Phase 8. Only after you've established the failure mode with eval queries — hybrid is not free. |
|
||||
| "Make a tool that submits doc bugs" | Read PLAN.md Phase 12. Find the docs portal's feedback endpoint by sniffing. Build with operator confirmation as a hard requirement in the tool docstring. |
|
||||
| "I want a 'what changed' tool" | Read PLAN.md Phase 13. Don't try to do this at runtime — pre-bake the history JSONL at CI time. |
|
||||
|
||||
## Out-of-scope concerns (don't try to solve here)
|
||||
|
||||
Reference in New Issue
Block a user