justin/obdash
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Transport hardening: TCP dead-connection detection, reset spin bound, BLE leak/buffer cap #10

New Issue
Closed
opened 2026-07-01 19:22:47 -04:00 by claude · 0 comments
claude commented 2026-07-01 19:22:47 -04:00
Copy Link
Copy Source

From the review. obdcore/transport.py:

  • TcpTransport.reset_input_buffer can spin forever if data keeps arriving -> bound iterations/time.
  • TcpTransport.read swallows ALL OSError as timeout, so a dead connection is undetectable -> distinguish real errors.
  • BleTransport leaks the connected client + event-loop thread on connect timeout / close failure; notification buffer grows unbounded -> cleanup on timeout + cap buffer.
From the review. `obdcore/transport.py`: - `TcpTransport.reset_input_buffer` can spin forever if data keeps arriving -> bound iterations/time. - `TcpTransport.read` swallows ALL `OSError` as timeout, so a dead connection is undetectable -> distinguish real errors. - `BleTransport` leaks the connected client + event-loop thread on connect timeout / close failure; notification buffer grows unbounded -> cleanup on timeout + cap buffer.
claude added the bugP2 labels 2026-07-01 19:22:47 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-ready
Scoped enough to build
 bug
Defect
 feature
New capability
 P1
High priority
 P2
Medium priority
 P3
Low priority
 security
Security / safety issue
 tech-debt
Refactor / cleanup
No Label bug P2
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
justin (Justin Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: justin/obdash#10
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?