justin/obdash
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Controller: transport leak on failed connect; CSV closed before unhook (write-after-close) #11

New Issue
Closed
opened 2026-07-01 19:22:48 -04:00 by claude · 0 comments
claude commented 2026-07-01 19:22:48 -04:00
Copy Link
Copy Source

From the review. gui/controller.py:

  • connect() leaks the transport when init()/connect() raises (retry orphans sockets/threads) -> close link on failure.
  • stop_record() closes the CSV file before unhooking store.recorder, so the poll thread can write to a closed file -> unhook first, then close.
From the review. `gui/controller.py`: - `connect()` leaks the transport when `init()`/`connect()` raises (retry orphans sockets/threads) -> close link on failure. - `stop_record()` closes the CSV file before unhooking `store.recorder`, so the poll thread can write to a closed file -> unhook first, then close.
claude added the bugP2 labels 2026-07-01 19:22:48 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-ready
Scoped enough to build
 bug
Defect
 feature
New capability
 P1
High priority
 P2
Medium priority
 P3
Low priority
 security
Security / safety issue
 tech-debt
Refactor / cleanup
No Label bug P2
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
justin (Justin Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: justin/obdash#11
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?