justin
04ccdbf96a
Names (the genealogy standard: maiden name primary, married/alias as typed
alternates):
- Name model already supported multiple typed names; expose full CRUD —
NameCreate/Read/Update schemas, name_service (one-primary invariant,
promote-on-delete), nested /persons/{id}/names routes.
- Person page gains a Names card: add/edit/delete + "make primary", with a
curated name_type dropdown (birth/maiden, married, alias, nickname, …).
Self-person ("who am I"):
- users.self_person_id FK (use_alter for the users<->persons<->trees cycle)
+ migration; PATCH /users/me/self-person; "This is me" / "This is you"
on the person page. Soft-deleting the linked person clears it.
Deletion integrity (fixes the broken tree view):
- delete_person now soft-deletes the relationships touching the person, so no
dangling edges remain; family-chart also filters links to missing people.
- Optional cascade=true recursively deletes descendants (GEDCOM cleanup);
the person page asks "only this person" vs "with all descendants".
- DELETE returns {deleted: n}.
Family view surfaces "Not connected to anyone" so dangling people aren't lost.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
115 lines
3.9 KiB
Python
115 lines
3.9 KiB
Python
import uuid
|
|
|
|
from fastapi import APIRouter, status
|
|
|
|
from app.api.deps import CurrentUser, SessionDep
|
|
from app.schemas.person import PersonCreate, PersonRead, PersonUpdate
|
|
from app.services import person_service, tree_service
|
|
|
|
# Persons are nested under their tree (the tenant boundary).
|
|
router = APIRouter(prefix="/trees", tags=["persons"])
|
|
|
|
|
|
@router.post(
|
|
"/{tree_id}/persons",
|
|
response_model=PersonRead,
|
|
status_code=status.HTTP_201_CREATED,
|
|
)
|
|
async def create_person(
|
|
tree_id: uuid.UUID, data: PersonCreate, session: SessionDep, current: CurrentUser
|
|
) -> PersonRead:
|
|
# get_tree enforces existence + view access; create_person enforces edit rights.
|
|
tree = await tree_service.get_tree(session, viewer_id=current.id, tree_id=tree_id)
|
|
person = await person_service.create_person(
|
|
session,
|
|
actor=current,
|
|
tree=tree,
|
|
given=data.given,
|
|
surname=data.surname,
|
|
gender=data.gender,
|
|
is_living=data.is_living,
|
|
privacy_setting=data.privacy,
|
|
notes=data.notes,
|
|
)
|
|
return PersonRead.model_validate(person)
|
|
|
|
|
|
@router.get("/{tree_id}/persons", response_model=list[PersonRead])
|
|
async def list_persons(
|
|
tree_id: uuid.UUID,
|
|
session: SessionDep,
|
|
current: CurrentUser,
|
|
deleted: bool = False,
|
|
q: str | None = None,
|
|
) -> list[PersonRead]:
|
|
tree = await tree_service.get_tree(session, viewer_id=current.id, tree_id=tree_id)
|
|
if q:
|
|
persons = await person_service.search_persons(
|
|
session, viewer_id=current.id, tree=tree, query=q
|
|
)
|
|
elif deleted:
|
|
persons = await person_service.list_deleted_persons(
|
|
session, viewer_id=current.id, tree=tree
|
|
)
|
|
else:
|
|
persons = await person_service.list_persons(session, viewer_id=current.id, tree=tree)
|
|
return [PersonRead.model_validate(p) for p in persons]
|
|
|
|
|
|
@router.patch("/{tree_id}/persons/{person_id}", response_model=PersonRead)
|
|
async def update_person(
|
|
tree_id: uuid.UUID,
|
|
person_id: uuid.UUID,
|
|
data: PersonUpdate,
|
|
session: SessionDep,
|
|
current: CurrentUser,
|
|
) -> PersonRead:
|
|
tree = await tree_service.get_tree(session, viewer_id=current.id, tree_id=tree_id)
|
|
person = await person_service.update_person(
|
|
session,
|
|
actor=current,
|
|
tree=tree,
|
|
person_id=person_id,
|
|
changes=data.model_dump(exclude_unset=True),
|
|
)
|
|
return PersonRead.model_validate(person)
|
|
|
|
|
|
@router.delete("/{tree_id}/persons/{person_id}")
|
|
async def delete_person(
|
|
tree_id: uuid.UUID,
|
|
person_id: uuid.UUID,
|
|
session: SessionDep,
|
|
current: CurrentUser,
|
|
cascade: bool = False,
|
|
) -> dict[str, int]:
|
|
"""Delete a person. ``cascade=true`` also deletes all descendants. Returns
|
|
the number of persons deleted (1 unless cascading)."""
|
|
tree = await tree_service.get_tree(session, viewer_id=current.id, tree_id=tree_id)
|
|
deleted = await person_service.delete_person(
|
|
session, actor=current, tree=tree, person_id=person_id, cascade=cascade
|
|
)
|
|
return {"deleted": deleted}
|
|
|
|
|
|
@router.post("/{tree_id}/persons/{person_id}/restore", response_model=PersonRead)
|
|
async def restore_person(
|
|
tree_id: uuid.UUID, person_id: uuid.UUID, session: SessionDep, current: CurrentUser
|
|
) -> PersonRead:
|
|
tree = await tree_service.get_tree(session, viewer_id=current.id, tree_id=tree_id)
|
|
person = await person_service.restore_person(
|
|
session, actor=current, tree=tree, person_id=person_id
|
|
)
|
|
return PersonRead.model_validate(person)
|
|
|
|
|
|
@router.get("/{tree_id}/persons/{person_id}", response_model=PersonRead)
|
|
async def get_person(
|
|
tree_id: uuid.UUID, person_id: uuid.UUID, session: SessionDep, current: CurrentUser
|
|
) -> PersonRead:
|
|
tree = await tree_service.get_tree(session, viewer_id=current.id, tree_id=tree_id)
|
|
person = await person_service.get_person(
|
|
session, viewer_id=current.id, tree=tree, person_id=person_id
|
|
)
|
|
return PersonRead.model_validate(person)
|