justin
a6179037c2
Two changes. 1. Privacy fix (NN#2/NN#3) — the citation and source list endpoints gated only on can_view_tree, so a non-member on a public/unlisted/site_members tree could enumerate citations and sources tied to a redacted living person, leaking that the person exists and has sourced facts (and possibly their name via a source title). #46 closed this for events/media/names/relationships but not citations/sources. Now citation_service.list_citations and source_service.{list_sources,get_source} delegate non-member reads to public_view_service, mirroring the #46 pattern: - citations: shown only when the cited fact resolves to FULL-visibility person(s) — covers the person_id, name_id, event_id (person or both-partner), and relationship_id (both-partner) target paths. - sources: shown only when they back at least one visible citation; a withheld source 404s (don't reveal it exists). Tests cover all four citation target types + source withholding + member-sees-all. 2. On-demand tree purge — owners can permanently delete a soft-deleted tree now instead of waiting out the 30-day auto-purge window. POST /trees/{id}/purge (owner-only): the tree must already be in the trash, and the caller retypes its name to confirm. Media objects are deleted from storage, then a single DELETE on trees cascades all tree-owned rows via the tree_id ON DELETE CASCADE; the audit entry survives (tree_id SET NULL). Frontend adds a "Delete forever" button to the Recently-deleted list. No migration. Suite: 102 passing. Signed-off-by: Justin Paul <justin@jpaul.me>
50 lines
1.2 KiB
Python
50 lines
1.2 KiB
Python
import uuid
|
|
from datetime import datetime
|
|
|
|
from pydantic import BaseModel, ConfigDict
|
|
|
|
from app.models.enums import TreeVisibility
|
|
|
|
|
|
class TreeCreate(BaseModel):
|
|
name: str
|
|
description: str | None = None
|
|
visibility: TreeVisibility = TreeVisibility.private
|
|
|
|
|
|
class TreeUpdate(BaseModel):
|
|
name: str | None = None
|
|
description: str | None = None
|
|
visibility: TreeVisibility | None = None
|
|
home_person_id: uuid.UUID | None = None
|
|
|
|
|
|
class TreePurge(BaseModel):
|
|
# Retype the tree's name to confirm a permanent, irreversible delete.
|
|
confirm_name: str
|
|
|
|
|
|
class TreeRead(BaseModel):
|
|
model_config = ConfigDict(from_attributes=True)
|
|
|
|
id: uuid.UUID
|
|
name: str
|
|
description: str | None
|
|
visibility: TreeVisibility
|
|
owner_id: uuid.UUID
|
|
home_person_id: uuid.UUID | None = None
|
|
created_at: datetime
|
|
|
|
|
|
class PublicTreeRead(BaseModel):
|
|
"""Tree projection for the public surface — deliberately omits owner_id so a
|
|
public/unlisted tree doesn't reveal which account owns it."""
|
|
|
|
model_config = ConfigDict(from_attributes=True)
|
|
|
|
id: uuid.UUID
|
|
name: str
|
|
description: str | None
|
|
visibility: TreeVisibility
|
|
home_person_id: uuid.UUID | None = None
|