zerto/ZertoApiWrapper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update logic to only allow install to attached devices

Browse Source
This commit is contained in:
Wes Carroll
2020-04-01 17:14:21 -04:00
parent de08f0eece
commit 2ea7092b91
2 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Tests/Public/Install-ZertoVra.Tests.ps1
+3 -3
View File
@@ -5,8 +5,8 @@ $global:function = ((Split-Path -leaf $MyInvocation.MyCommand.Path).Split('.'))[
Describe $global:function -Tag 'Unit', 'Source', 'Built' { Describe $global:function -Tag 'Unit', 'Source', 'Built' {
Context "$global:function::Parameter Unit Tests" { Context "$global:function::Parameter Unit Tests" {
it "$global:function should have exactly 22 parameters defined" { It "$global:function should have exactly 22 parameters defined" {
(get-command $global:function).Parameters.Count | Should -Be 22 (Get-Command $global:function).Parameters.Count | Should -Be 22
} }
$ParameterTestCases = @( $ParameterTestCases = @(
@@ -35,7 +35,7 @@ Describe $global:function -Tag 'Unit', 'Source', 'Built' {
'IpAddr' { 'IpAddr' {
$attrs = (Get-Command $global:function).Parameters[$ParameterName].Attributes $attrs = (Get-Command $global:function).Parameters[$ParameterName].Attributes
$attrs.Where{ $_ -is [ValidateScript] }.Count | Should -Be 1 $attrs.Where{ $_ -is [ValidateScript] }.Count | Should -Be 1
$attrs.Where{ $_ -is [ValidateScript] }.ScriptBlock | Should -Match '^\$_ \-match \[IPAddress\]\$_' $attrs.Where{ $_ -is [ValidateScript] }.ScriptBlock | Should -Match '\$_ \-match \[IPAddress\]\$_'
} }
$null { $null {
ZertoApiWrapper/Public/Install-ZertoVra.ps1
+15 -11
View File
@@ -21,13 +21,13 @@ function Install-ZertoVra {
[Parameter( ParameterSetName = "Dhcp", Mandatory = $true, HelpMessage = "Assign a DHCP address to the VRA." )] [Parameter( ParameterSetName = "Dhcp", Mandatory = $true, HelpMessage = "Assign a DHCP address to the VRA." )]
[switch]$Dhcp, [switch]$Dhcp,
[Parameter( ParameterSetName = "StaticIp", Mandatory = $true, HelpMessage = "Static IP address to assign to the VRA." )] [Parameter( ParameterSetName = "StaticIp", Mandatory = $true, HelpMessage = "Static IP address to assign to the VRA." )]
[ValidateScript( {$_ -match [IPAddress]$_ })] [ValidateScript( { $_ -match [IPAddress]$_ })]
[string]$vraIpAddress, [string]$vraIpAddress,
[Parameter( ParameterSetName = "StaticIp", Mandatory = $true, HelpMessage = "Default gateway to assign to the VRA" )] [Parameter( ParameterSetName = "StaticIp", Mandatory = $true, HelpMessage = "Default gateway to assign to the VRA" )]
[ValidateScript( {$_ -match [IPAddress]$_ })] [ValidateScript( { $_ -match [IPAddress]$_ })]
[string]$defaultGateway, [string]$defaultGateway,
[Parameter( ParameterSetName = "StaticIp", Mandatory = $true, HelpMessage = "Subnetmask to be assigned to the VRA" )] [Parameter( ParameterSetName = "StaticIp", Mandatory = $true, HelpMessage = "Subnetmask to be assigned to the VRA" )]
[ValidateScript( {$_ -match [IPAddress]$_ })] [ValidateScript( { $_ -match [IPAddress]$_ })]
[string]$subnetMask [string]$subnetMask
) )
@@ -37,20 +37,24 @@ function Install-ZertoVra {
if ( -not (Get-ZertoVra -vraName $vraName) ) { if ( -not (Get-ZertoVra -vraName $vraName) ) {
# Get identifiers for each item provided by name. # Get identifiers for each item provided by name.
$siteIdentifier = $script:zvmLocalInfo.SiteIdentifier $siteIdentifier = $script:zvmLocalInfo.SiteIdentifier
$hostIdentifier = Get-ZertoVirtualizationSite -siteIdentifier $siteIdentifier -hosts | Where-Object {$_.VirtualizationHostName -eq $hostName} | Select-Object hostIdentifier -ExpandProperty hostIdentifier $hostIdentifier = Get-ZertoVirtualizationSite -siteIdentifier $siteIdentifier -hosts | Where-Object { $_.VirtualizationHostName -eq $hostName } | Select-Object hostIdentifier -ExpandProperty hostIdentifier
$networkIdentifier = Get-ZertoVirtualizationSite -siteIdentifier $siteIdentifier -networks | Where-Object {$_.VirtualizationNetworkName -eq $networkName} | Select-Object NetworkIdentifier -ExpandProperty NetworkIdentifier $networkIdentifier = Get-ZertoVirtualizationSite -siteIdentifier $siteIdentifier -networks | Where-Object { $_.VirtualizationNetworkName -eq $networkName } | Select-Object NetworkIdentifier -ExpandProperty NetworkIdentifier
$datastoreIdentifier = Get-ZertoVirtualizationSite -siteIdentifier $siteIdentifier -datastores | Where-Object {$_.DatastoreName -eq $datastoreName} | Select-Object DatastoreIdentifier -ExpandProperty DatastoreIdentifier $datastoreIdentifier = Get-ZertoVirtualizationSite -siteIdentifier $siteIdentifier -datastores | Where-Object { $_.DatastoreName -eq $datastoreName } | Select-Object DatastoreIdentifier -ExpandProperty DatastoreIdentifier
if ($datastoreIdentifier.count -gt 1){ if ($datastoreIdentifier.count -gt 1) {
$hostDevices = Get-ZertoVirtualizationSite -siteIdentifier $siteIdentifier -devices -hostIdentifier $hostIdentifier $hostDevices = Get-ZertoVirtualizationSite -siteIdentifier $siteIdentifier -devices -hostIdentifier $hostIdentifier
$datastoreIdentifier = foreach ($identifier in $datastoreIdentifier) { $datastoreIdentifier = foreach ($identifier in $datastoreIdentifier) {
if ($identifier -in $hostDevices.DatastoreIdentifier){ if ($identifier -in $hostDevices.DatastoreIdentifier) {
$identifier $identifier
} }
} }
if ($datastoreIdentifier.count -gt 1) {
Write-Error "Datastore $datastoreName has more than one identifier associated with it on the specified host. Please review and try again."
Break
}
} }
# Build the JSON object through an Ordered Hashtable. # Build the JSON object through an Ordered Hashtable.
$vraBasic = [ordered]@{} $vraBasic = [ordered]@{ }
$vraBasic['DatastoreIdentifier'] = $datastoreIdentifier.toString() $vraBasic['DatastoreIdentifier'] = $datastoreIdentifier.toString()
if ($PSBoundParameters.ContainsKey('groupName')) { if ($PSBoundParameters.ContainsKey('groupName')) {
$vraBasic['GroupName'] = $groupName $vraBasic['GroupName'] = $groupName
@@ -59,7 +63,7 @@ function Install-ZertoVra {
$vraBasic['MemoryInGB'] = $memoryInGB $vraBasic['MemoryInGB'] = $memoryInGB
$vraBasic['NetworkIdentifier'] = $networkIdentifier.toString() $vraBasic['NetworkIdentifier'] = $networkIdentifier.toString()
$vraBasic['UsePublicKeyInsteadOfCredentials'] = $true $vraBasic['UsePublicKeyInsteadOfCredentials'] = $true
$vraBasicNetwork = [ordered]@{} $vraBasicNetwork = [ordered]@{ }
if ( $PSCmdlet.ParameterSetName -eq "StaticIp" ) { if ( $PSCmdlet.ParameterSetName -eq "StaticIp" ) {
$vraBasicNetwork['DefaultGateway'] = $defaultGateway.toString() $vraBasicNetwork['DefaultGateway'] = $defaultGateway.toString()
$vraBasicNetwork['SubnetMask'] = $subnetMask.toString() $vraBasicNetwork['SubnetMask'] = $subnetMask.toString()
@@ -71,7 +75,7 @@ function Install-ZertoVra {
$vraBasic['VraNetworkDataApi'] = $vraBasicNetwork $vraBasic['VraNetworkDataApi'] = $vraBasicNetwork
# Leverage WhatIf functionality to see what might happen, if WhatIf is not specified, attempt to install. # Leverage WhatIf functionality to see what might happen, if WhatIf is not specified, attempt to install.
if ($PSCmdlet.ShouldProcess("Preforming operation 'Install-Vra' on Host $hostName with the following data \n $($vraBasic | convertto-json)")) { if ($PSCmdlet.ShouldProcess("Preforming operation 'Install-Vra' on Host $hostName with the following data \n $($vraBasic | ConvertTo-Json)")) {
Invoke-ZertoRestRequest -uri "vras" -method POST -body $($vraBasic | ConvertTo-Json) Invoke-ZertoRestRequest -uri "vras" -method POST -body $($vraBasic | ConvertTo-Json)
} }
} else { } else {