Validate identifiers are present

ZertoApiWrapper/Public/Edit-ZertoVra.ps1

@@ -38,6 +38,9 @@ function Edit-ZertoVra {
         $baseUri = "vras/{0}" -f $vraIdentifier
         # Get the current VRA information for use if an updated parameter is not supplied
         $vra = Get-ZertoVra -vraIdentifier $vraIdentifier
+        if ( -not $vra ) {
+            Write-Error "VRA with Identifier: $vraIdentifier could not be found. Please check the ID and try again."
+        }
     }
 
     process {

ZertoApiWrapper/Public/Invoke-ZertoFailover.ps1

@@ -2,6 +2,7 @@
 function Invoke-ZertoFailover {
     [cmdletbinding( SupportsShouldProcess = $true )]
     param(
+        #TODO - Refactor?
         [Parameter(
             Mandatory = $true,
             HelpMessage = "Name of the VPG to Failover"

ZertoApiWrapper/Public/Invoke-ZertoFailoverCommit.ps1

@@ -25,8 +25,12 @@ function Invoke-ZertoFailoverCommit {
     process {
         foreach ($name in $vpgName) {
             $vpgId = $(Get-ZertoVpg -name $name).vpgIdentifier
-            $uri = "{0}/{1}/FailoverCommit" -f $baseUri, $vpgId
+            if ( -not $vpgId ) {
-            Invoke-ZertoRestRequest -uri $uri -body $($body | convertto-json) -method "POST"
+                Write-Error "VPG: $name could not be found. Please check the name and try again. Skipping."
+            } else {
+                $uri = "{0}/{1}/FailoverCommit" -f $baseUri, $vpgId
+                Invoke-ZertoRestRequest -uri $uri -body $($body | convertto-json) -method "POST"
+            }
         }
     }
 

ZertoApiWrapper/Public/Invoke-ZertoFailoverRollback.ps1

@@ -16,8 +16,12 @@ function Invoke-ZertoFailoverRollback {
     process {
         foreach ($name in $vpgName) {
             $vpgId = $(Get-ZertoVpg -name $name).vpgIdentifier
-            $uri = "{0}/{1}/FailoverRollback" -f $baseUri, $vpgId
+            if ( -not $vpgId ) {
-            Invoke-ZertoRestRequest -uri $uri -method "POST"
+                Write-Error "VPG: $name not found. Please check the name and try again. Skipping"
+            } else {
+                $uri = "{0}/{1}/FailoverRollback" -f $baseUri, $vpgId
+                Invoke-ZertoRestRequest -uri $uri -method "POST"
+            }
         }
     }
 

ZertoApiWrapper/Public/Invoke-ZertoForceSync.ps1

@@ -16,8 +16,12 @@ function Invoke-ZertoForceSync {
     process {
         foreach ($name in $vpgName) {
             $id = $(Get-ZertoVpg -name $name).vpgIdentifier
-            $uri = "{0}/{1}/forcesync" -f $baseUri, $id
+            if ( -not $id ) {
-            Invoke-ZertoRestRequest -uri $uri -method "POST"
+                Write-Error "VPG: $name not found. Please check the name and try again. Skipping"
+            } else {
+                $uri = "{0}/{1}/forcesync" -f $baseUri, $id
+                Invoke-ZertoRestRequest -uri $uri -method "POST"
+            }
         }
     }
 

ZertoApiWrapper/Public/Invoke-ZertoMove.ps1

@@ -49,6 +49,7 @@ function Invoke-ZertoMove {
     begin {
         $baseUri = "vpgs"
         $body = [ordered]@{}
+        #TODO - use a foreach loop to populate the body without all the if statments
         if ($PSBoundParameters.ContainsKey('commitPolicy')) {
             $body['commitPolicy'] = $commitPolicy
         }
@@ -72,8 +73,12 @@ function Invoke-ZertoMove {
     process {
         foreach ($name in $vpgName) {
             $vpgId = $(Get-ZertoVpg -name $name).vpgIdentifier
-            $uri = "{0}/{1}/move" -f $baseUri, $vpgId
+            if ( -not $vpgId ) {
-            Invoke-ZertoRestRequest -uri $uri -method "POST" -body $($body | ConvertTo-Json)
+                Write-Error "VPG: $name not found. Please check the name and try again. Skipping"
+            } else {
+                $uri = "{0}/{1}/move" -f $baseUri, $vpgId
+                Invoke-ZertoRestRequest -uri $uri -method "POST" -body $($body | ConvertTo-Json)
+            }
         }
     }
 

ZertoApiWrapper/Public/Invoke-ZertoMoveCommit.ps1

@@ -29,8 +29,12 @@ function Invoke-ZertoMoveCommit {
     process {
         foreach ($name in $vpgName) {
             $vpgId = $(Get-ZertoVpg -name $name).vpgIdentifier
-            $uri = "{0}/{1}/MoveCommit" -f $baseUri, $vpgId
+            if ( -not $vpgId ) {
-            Invoke-ZertoRestRequest -uri $uri -body $($body | convertto-json) -method "POST"
+                Write-Error "VPG: $name not found. Please check the name and try again. Skipping."
+            } else {
+                $uri = "{0}/{1}/MoveCommit" -f $baseUri, $vpgId
+                Invoke-ZertoRestRequest -uri $uri -body $($body | convertto-json) -method "POST"
+            }
         }
     }
 

ZertoApiWrapper/Public/Invoke-ZertoMoveRollback.ps1

@@ -16,8 +16,12 @@ function Invoke-ZertoMoveRollback {
     process {
         foreach ($name in $vpgName) {
             $id = $(Get-ZertoVpg -name $name).vpgIdentifier
-            $uri = "{0}/{1}/moveRollBack" -f $baseUri, $id
+            if ( -not $id ) {
-            Invoke-ZertoRestRequest -uri $uri -method "POST"
+                Write-Error "VPG: $name not found. Please check the name and try again."
+            } else {
+                $uri = "{0}/{1}/moveRollBack" -f $baseUri, $id
+                Invoke-ZertoRestRequest -uri $uri -method "POST"
+            }
         }
     }
 

ZertoApiWrapper/Public/New-ZertoVpg.ps1

@@ -241,8 +241,7 @@ function New-ZertoVpg {
         }
 
         if ( -not $validSettings ) {
-            Write-Error "One or more parameters passed do not have valid identifiers or 0 valid VMs were found. Please check your settings and try again."
+            Write-Error "One or more parameters passed do not have valid identifiers or 0 valid VMs were found. Please check your settings and try again." -ErrorAction Stop
-            Break
         }
     }
 

ZertoApiWrapper/Public/New-ZertoVpgSettingsIdentifier.ps1

@@ -36,10 +36,9 @@ function New-ZertoVpgSettingsIdentifier {
         if ($PSCmdlet.ShouldProcess("Creating VPG Settings Object")) {
             Invoke-ZertoRestRequest -uri $baseUri -body $body -Method "POST"
         }
-
     }
 
     end {
-
+        #Nothing to do
     }
 }

ZertoApiWrapper/Public/Remove-ZertoVpg.ps1

@@ -55,7 +55,7 @@ function Remove-ZertoVpg {
                             Invoke-ZertoRestRequest -uri $uri -body $($body | ConvertTo-Json) -Method "DELETE"
                         }
                     } else {
-                        Write-Output "VPG with name $vpgName not found. Please check the name and try again"
+                        Write-Error "VPG with name $vpgName not found. Please check the name and try again"
                     }
                 }
             }

ZertoApiWrapper/Public/Resume-ZertoVpg.ps1

@@ -16,8 +16,12 @@ function Resume-ZertoVpg {
     process {
         foreach ($name in $vpgName) {
             $id = $(Get-ZertoVpg -name $name).vpgIdentifier
-            $uri = "{0}/{1}/resume" -f $baseUri, $id
+            if ( -not $id ) {
-            Invoke-ZertoRestRequest -uri $uri -method "POST"
+                Write-Error "VPG: $name not found. Please check the name and try again. Skipping."
+            } else {
+                $uri = "{0}/{1}/resume" -f $baseUri, $id
+                Invoke-ZertoRestRequest -uri $uri -method "POST"
+            }
         }
     }
 

ZertoApiWrapper/Public/Start-ZertoCloneVpg.ps1

@@ -24,18 +24,35 @@ function Start-ZertoCloneVpg {
 
     begin {
         $baseUri = "vpgs"
-
         $vpgInfo = Get-ZertoVpg -name $vpgName
+        if ( -not $vpgInfo ) {
+            Write-Error "VPG: $vpgName could not be found. Please check the name and try again."
+        }
         $vpgIdentifier = $vpgInfo.vpgIdentifier
         if ( $PSBoundParameters.ContainsKey('datastoreName') ) {
             $recoverysiteIdentifier = $vpgInfo.recoverysite.identifier
             $recoverySiteDatastores = Get-ZertoVirtualizationSite -siteIdentifier $recoverysiteIdentifier -datastores
             $datastoreIdentifier = $($recoverySiteDatastores | Where-Object {$_.datastoreName -like $datastoreName}).DatastoreIdentifier
+            if ( -not $datastoreIdentifier ) {
+                Write-Error "Datastore: $datastoreName is not a valid datastore. Please check the name and try again." -ErrorAction Stop
+            }
         }
         if ( $PSBoundParameters.ContainsKey('vmName') ) {
-            $vmIdentifiers = @()
+            $vpgVmInformation = Get-ZertoProtectedVm -vpgName $vpgName
-            $vmIdentifiers = foreach ( $name in $vmName ) {
+            [System.Collections.ArrayList]$vmIdentifiers = @()
-                $(Get-ZertoProtectedVm -vmName $name).vmIdentifier
+            foreach ( $name in $vmName ) {
+                $selectedVm = $vpgVmInformation | Where-Object {$_.VmName.toLower() -eq $name.toLower()}
+                if ($null -eq $selectedVm) {
+                    Write-Error "VM: $name NOT found in VPG $vpgName. Check the name and try again." -ErrorAction Stop
+                } elseif ($vmIdentifiers.Contains($selectedVm.vmIdentifier.toString())) {
+                    Write-Error "VM: $($selectedVm.VmName) specified more than once. Please check parameters and try again." -ErrorAction Stop
+                } else {
+                    $vmIdentifiers.Add($selectedVm.vmIdentifier.toString()) | Out-Null
+                }
+            }
+            $body['VmIdentifiers'] = $vmIdentifiers
+            if ($checkpointIdentifier) {
+                $body['CheckpointIdentifier'] = $checkpointIdentifier
             }
         }
     }

ZertoApiWrapper/Public/Start-ZertoFailoverTest.ps1

@@ -21,32 +21,34 @@ function Start-ZertoFailoverTest {
     begin {
         $baseUri = "vpgs"
         $vpgIdentifier = $(Get-ZertoVpg -name $vpgName).vpgIdentifier
+        if ( -not $vpgIdentifier) {
+            Write-Error "VPG: $vpgName Not Found. Please check the name and try again!" -ErrorAction Stop
+        }
         if ( $PSBoundParameters.ContainsKey('vmName') ) {
-            $vmIdentifiers = @()
+            $vpgVmInformation = Get-ZertoProtectedVm -vpgName $vpgName
-            $vmIdentifiers = foreach ( $name in $vmName ) {
+            [System.Collections.ArrayList]$vmIdentifiers = @()
-                $(Get-ZertoProtectedVm -vmName $name).vmIdentifier
+            foreach ( $name in $vmName ) {
+                $selectedVm = $vpgVmInformation | Where-Object {$_.VmName.toLower() -eq $name.toLower()}
+                if ($null -eq $selectedVm) {
+                    Write-Error "VM: $name NOT found in VPG $vpgName. Check the name and try again." -ErrorAction Stop
+                } elseif ($vmIdentifiers.Contains($selectedVm.vmIdentifier.toString())) {
+                    Write-Error "VM: $($selectedVm.VmName) specified more than once. Please check parameters and try again." -ErrorAction Stop
+                } else {
+                    $vmIdentifiers.Add($selectedVm.vmIdentifier.toString()) | Out-Null
+                }
+            }
+            $body['VmIdentifiers'] = $vmIdentifiers
+            if ($checkpointIdentifier) {
+                $body['CheckpointIdentifier'] = $checkpointIdentifier
             }
         }
     }
 
     process {
         $uri = "{0}/{1}/FailoverTest" -f $baseUri, $vpgIdentifier
-        $body = [ordered]@{}
+        if ($PSCmdlet.ShouldProcess($vpgName)) {
-        if ($checkpointIdentifier) {
-            $body['CheckpointIdentifier'] = $checkpointIdentifier
-        }
-        if ( $PSBoundParameters.ContainsKey('vmName') ) {
-            $vmIdentifiers = @()
-            $vmIdentifiers = foreach ( $name in $vmName ) {
-                $(Get-ZertoProtectedVm -vmName $name).vmIdentifier
-            }
-            $body['VmIdentifiers'] = $vmIdentifiers
-        }
-        if ($PSCmdlet.ShouldProcess("Starting Failover Test")) {
             Invoke-ZertoRestRequest -uri $uri -method "POST" -body $($body | ConvertTo-Json)
         }
-
-
     }
 
     end {

ZertoApiWrapper/Public/Stop-ZertoCloneVpg.ps1

@@ -12,6 +12,9 @@ function Stop-ZertoCloneVpg {
     begin {
         $baseUri = "vpgs"
         $vpgIdentifier = $(Get-ZertoVpg -name $vpgName).vpgIdentifier
+        if ( -not $vpgIdentifier ) {
+            Write-Error "VPG: $vpgName could not be found. Please check the name and try again." -ErrorAction Stop
+        }
     }
 
     process {

ZertoApiWrapper/Public/Stop-ZertoFailoverTest.ps1

@@ -6,6 +6,7 @@ function Stop-ZertoFailoverTest {
             HelpMessage = "Name(s) of VPG(s) to stop testing.",
             Mandatory = $true
         )]
+        [ValidateNotNullOrEmpty()]
         [string[]]$vpgName,
         [Parameter(
             HelpMessage = "Was the test successful? True or False. True is Default."
@@ -25,11 +26,13 @@ function Stop-ZertoFailoverTest {
     process {
         foreach ($name in $vpgName) {
             $vpgId = $(Get-ZertoVpg -name $name).vpgIdentifier
+            if ( -not $vpgId) {
+                Write-Error "VPG: $vpgName Not Found. Please check the name and try again!" -ErrorAction Stop
+            }
             $uri = "{0}/{1}/FailoverTestStop" -f $baseUri, $vpgId
             if ($PSCmdlet.ShouldProcess("Stopping Failover Test")) {
                 Invoke-ZertoRestRequest -uri $uri -method "POST" -body $($body | ConvertTo-Json)
             }
-
         }
     }
 

ZertoApiWrapper/Public/Suspend-ZertoVpg.ps1

@@ -16,8 +16,12 @@ function Suspend-ZertoVpg {
     process {
         foreach ($name in $vpgName) {
             $id = $(Get-ZertoVpg -name $name).vpgIdentifier
-            $uri = "{0}/{1}/pause" -f $baseUri, $id
+            if ( -not $id ) {
-            Invoke-ZertoRestRequest -uri $uri -method "POST"
+                Write-Error "VPG: $name not found. Skipping."
+            } else {
+                $uri = "{0}/{1}/pause" -f $baseUri, $id
+                Invoke-ZertoRestRequest -uri $uri -method "POST"
+            }
         }
     }
 

ZertoApiWrapper/Public/Uninstall-ZertoVra.ps1

@@ -17,8 +17,12 @@ function Uninstall-ZertoVra {
         foreach ($name in $hostName) {
             $vraName = "Z-VRA-{0}" -f $name
             $vraIdentifier = get-zertovra -vraName $vraName | Select-Object vraIdentifier -ExpandProperty vraIdentifier
-            $uri = "{0}/{1}" -f $baseUri, $vraIdentifier.toString()
+            if ( -not $vraIdentifier ) {
-            Invoke-ZertoRestRequest -uri $uri -method "DELETE"
+                Write-Error "Host: $hostName either does not have a VRA or was not found. Please check the name and try again. Skipping."
+            } else {
+                $uri = "{0}/{1}" -f $baseUri, $vraIdentifier.toString()
+                Invoke-ZertoRestRequest -uri $uri -method "DELETE"
+            }
             if ($hostName.Count -gt 1) {
                 Start-Sleep 1
             }