claude
389ac2e460
Apply the no-ai-slop standard (now binding in AGENTS.md): the em-dash character is banned outright (restructured, not blind-replaced), plus the banned word/phrase list (delve, leverage, robust, seamless, truly, unlock, etc.). 0 em-dashes remain in modules + capstone; the only "robust" left is the planted M10 ai-change.patch trap. Module H1 titles use a colon separator. All deliberate teaching devices preserved; labs compile/parse (py/sh/yaml/json); no junk. AGENTS.md updated with the hard no-slop rules. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TfzV5QvtPDz8LJS3Pu5VLT
25 lines
1.1 KiB
JSON
25 lines
1.1 KiB
JSON
{
|
|
"summary": "Adds a `clear` command. The core logic is fine, but the CLI handler never persists the change, so the command looks like it works while doing nothing on disk. No test covers the new behavior.",
|
|
"recommendation": "request_changes",
|
|
"comments": [
|
|
{
|
|
"file": "cli.py",
|
|
"line": 49,
|
|
"severity": "blocker",
|
|
"comment": "The `clear` branch never calls save(tlist). The list is emptied in memory and the process exits, so tasks.json is untouched. It prints 'cleared all tasks' but the next `list` shows everything still there, a silent no-op. Add save(tlist) before printing."
|
|
},
|
|
{
|
|
"file": "tasks.py",
|
|
"line": 28,
|
|
"severity": "suggestion",
|
|
"comment": "No test covers clear(). Add one that adds two tasks, calls clear(), and asserts the list is empty, matching the Module 13 suite style."
|
|
},
|
|
{
|
|
"file": "tasks.py",
|
|
"line": 28,
|
|
"severity": "nit",
|
|
"comment": "clear() rebinds with self.tasks = []; self.tasks.clear() is equivalent and avoids replacing the list object. Minor."
|
|
}
|
|
]
|
|
}
|