claude
2684095e2f
Co-authored-by: claude <claude@jpaul.io> Co-committed-by: claude <claude@jpaul.io>
25 lines
1.1 KiB
JSON
25 lines
1.1 KiB
JSON
{
|
|
"summary": "Adds a `clear` command. The core logic is fine, but the CLI handler never persists the change, so the command looks like it works while doing nothing on disk. No test covers the new behavior.",
|
|
"recommendation": "request_changes",
|
|
"comments": [
|
|
{
|
|
"file": "cli.py",
|
|
"line": 49,
|
|
"severity": "blocker",
|
|
"comment": "The `clear` branch never calls save(tlist). The list is emptied in memory and the process exits, so tasks.json is untouched. It prints 'cleared all tasks' but the next `list` shows everything still there — a silent no-op. Add save(tlist) before printing."
|
|
},
|
|
{
|
|
"file": "tasks.py",
|
|
"line": 28,
|
|
"severity": "suggestion",
|
|
"comment": "No test covers clear(). Add one that adds two tasks, calls clear(), and asserts the list is empty — matching the Module 13 suite style."
|
|
},
|
|
{
|
|
"file": "tasks.py",
|
|
"line": 28,
|
|
"severity": "nit",
|
|
"comment": "clear() rebinds with self.tasks = []; self.tasks.clear() is equivalent and avoids replacing the list object. Minor."
|
|
}
|
|
]
|
|
}
|