justin/provenance
1
0
Fork 0
Code Issues 173 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix #169: keep citation links on GEDCOM export #232

Merged
justin merged 1 commits from fix-gedcom-citation-export into main 2026-06-09 12:37:05 -04:00
Conversation 0 Commits 1 Files Changed 2
+92
justin commented 2026-06-09 12:37:04 -04:00
Owner
Copy Link
Copy Source

Export emitted SOUR records but never the per-fact SOUR links, so a Provenance→Provenance round-trip dropped the sources graph. Now emits citation links on the facts: person (1 SOUR+2 PAGE), name (2 SOUR under NAME), event (2 SOUR under the event, incl. partnership events in FAM), relationship (1 SOUR under FAM). Citations whose source didn't export are skipped.

Test: person + event citation round-trips export→import into a fresh tree with pages intact. GEDCOM suite 6 passed.

Closes #169

🤖 Generated with Claude Code

Export emitted SOUR records but never the per-fact SOUR **links**, so a Provenance→Provenance round-trip dropped the sources graph. Now emits citation links on the facts: person (`1 SOUR`+`2 PAGE`), name (`2 SOUR` under NAME), event (`2 SOUR` under the event, incl. partnership events in FAM), relationship (`1 SOUR` under FAM). Citations whose source didn't export are skipped. Test: person + event citation round-trips export→import into a fresh tree with pages intact. GEDCOM suite 6 passed. Closes #169 🤖 Generated with [Claude Code](https://claude.com/claude-code)
justin added 1 commit 2026-06-09 12:37:04 -04:00
Fix #169: keep citation links on GEDCOM export b4434cb5dd 
Export emitted SOUR records but never the per-fact SOUR links, so a
Provenance→Provenance round-trip destroyed the sources graph (citations were
dropped). Emit citation links on the facts they sit on:
- person-level → 1 SOUR @Sx@ (2 PAGE)
- name-level   → 2 SOUR under 1 NAME
- event-level  → 2 SOUR under the event (incl. partnership events in FAM)
- relationship → 1 SOUR under FAM
Citations whose source didn't export are skipped.

Test: a person + event citation round-trips through export→import into a fresh
tree with their pages intact. GEDCOM suite 6 passed.

Closes #169

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Signed-off-by: Justin Paul <[email protected]>
justin merged commit 6d3147e86d into main 2026-06-09 12:37:05 -04:00
justin deleted branch fix-gedcom-citation-export 2026-06-09 12:37:05 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area:ai
Area: ai
 area:api
Area: api
 area:charts
Area: charts
 area:collaboration
Area: collaboration
 area:dna
Area: dna
 area:i18n
Area: i18n
 area:maps
Area: maps
 area:media
Area: media
 area:mobile
Area: mobile
 area:performance
Area: performance
 area:privacy
Area: privacy
 area:property
Area: property
 area:research
Area: research
 area:search
Area: search
 area:sources
Area: sources
 area:standards
Area: standards
 area:tree
Area: tree
 blocked
Blocked on a prerequisite
 moscow:must
Must have
 moscow:nice
Nice to have
 moscow:should
Should have
 parked
Deliberately deferred
 priority:P0
Critical — do first
 priority:P1
High
 priority:P2
Medium / lower
 status:missing
Not built
 status:partial
Partly built
 status:planned
On roadmap, not built
 type:bug
Bug
 type:chore
Docs / infra / conformance
 type:feature
Feature
 type:security
Security / correctness
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
justin (Justin Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: justin/provenance#232