justin
04ccdbf96a
Names (the genealogy standard: maiden name primary, married/alias as typed
alternates):
- Name model already supported multiple typed names; expose full CRUD —
NameCreate/Read/Update schemas, name_service (one-primary invariant,
promote-on-delete), nested /persons/{id}/names routes.
- Person page gains a Names card: add/edit/delete + "make primary", with a
curated name_type dropdown (birth/maiden, married, alias, nickname, …).
Self-person ("who am I"):
- users.self_person_id FK (use_alter for the users<->persons<->trees cycle)
+ migration; PATCH /users/me/self-person; "This is me" / "This is you"
on the person page. Soft-deleting the linked person clears it.
Deletion integrity (fixes the broken tree view):
- delete_person now soft-deletes the relationships touching the person, so no
dangling edges remain; family-chart also filters links to missing people.
- Optional cascade=true recursively deletes descendants (GEDCOM cleanup);
the person page asks "only this person" vs "with all descendants".
- DELETE returns {deleted: n}.
Family view surfaces "Not connected to anyone" so dangling people aren't lost.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
91 lines
2.6 KiB
Python
91 lines
2.6 KiB
Python
import uuid
|
|
|
|
from fastapi import APIRouter, status
|
|
|
|
from app.api.deps import CurrentUser, SessionDep
|
|
from app.schemas.name import NameCreate, NameRead, NameUpdate
|
|
from app.services import name_service, tree_service
|
|
|
|
# Names are nested under their person (which is nested under the tree tenant).
|
|
router = APIRouter(prefix="/trees", tags=["names"])
|
|
|
|
|
|
@router.get("/{tree_id}/persons/{person_id}/names", response_model=list[NameRead])
|
|
async def list_names(
|
|
tree_id: uuid.UUID, person_id: uuid.UUID, session: SessionDep, current: CurrentUser
|
|
) -> list[NameRead]:
|
|
tree = await tree_service.get_tree(session, viewer_id=current.id, tree_id=tree_id)
|
|
names = await name_service.list_names(
|
|
session, viewer_id=current.id, tree=tree, person_id=person_id
|
|
)
|
|
return [NameRead.model_validate(n) for n in names]
|
|
|
|
|
|
@router.post(
|
|
"/{tree_id}/persons/{person_id}/names",
|
|
response_model=NameRead,
|
|
status_code=status.HTTP_201_CREATED,
|
|
)
|
|
async def create_name(
|
|
tree_id: uuid.UUID,
|
|
person_id: uuid.UUID,
|
|
data: NameCreate,
|
|
session: SessionDep,
|
|
current: CurrentUser,
|
|
) -> NameRead:
|
|
tree = await tree_service.get_tree(session, viewer_id=current.id, tree_id=tree_id)
|
|
name = await name_service.create_name(
|
|
session,
|
|
actor=current,
|
|
tree=tree,
|
|
person_id=person_id,
|
|
name_type=data.name_type,
|
|
given=data.given,
|
|
surname=data.surname,
|
|
prefix=data.prefix,
|
|
suffix=data.suffix,
|
|
nickname=data.nickname,
|
|
is_primary=data.is_primary,
|
|
)
|
|
return NameRead.model_validate(name)
|
|
|
|
|
|
@router.patch(
|
|
"/{tree_id}/persons/{person_id}/names/{name_id}", response_model=NameRead
|
|
)
|
|
async def update_name(
|
|
tree_id: uuid.UUID,
|
|
person_id: uuid.UUID,
|
|
name_id: uuid.UUID,
|
|
data: NameUpdate,
|
|
session: SessionDep,
|
|
current: CurrentUser,
|
|
) -> NameRead:
|
|
tree = await tree_service.get_tree(session, viewer_id=current.id, tree_id=tree_id)
|
|
name = await name_service.update_name(
|
|
session,
|
|
actor=current,
|
|
tree=tree,
|
|
person_id=person_id,
|
|
name_id=name_id,
|
|
changes=data.model_dump(exclude_unset=True),
|
|
)
|
|
return NameRead.model_validate(name)
|
|
|
|
|
|
@router.delete(
|
|
"/{tree_id}/persons/{person_id}/names/{name_id}",
|
|
status_code=status.HTTP_204_NO_CONTENT,
|
|
)
|
|
async def delete_name(
|
|
tree_id: uuid.UUID,
|
|
person_id: uuid.UUID,
|
|
name_id: uuid.UUID,
|
|
session: SessionDep,
|
|
current: CurrentUser,
|
|
) -> None:
|
|
tree = await tree_service.get_tree(session, viewer_id=current.id, tree_id=tree_id)
|
|
await name_service.delete_name(
|
|
session, actor=current, tree=tree, person_id=person_id, name_id=name_id
|
|
)
|